Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the variable column name for variables #29

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Use the variable column name for variables #29

merged 1 commit into from
Aug 4, 2021

Conversation

mgrover1
Copy link
Contributor

@mgrover1 mgrover1 commented Aug 4, 2021

I noticed that when we are building the list of base_variables, we use the column name variable which does not work when that column is different... here is an implementation using the variable_column_name we specify the line above.

@mgrover1 mgrover1 requested a review from andersy005 August 4, 2021 16:30
andersy005
andersy005 approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍🏽

@andersy005 andersy005 merged commit f79e8d0 into main Aug 4, 2021
@andersy005 andersy005 deleted the fix_variable_name_issue branch August 4, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersy005 andersy005 andersy005 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgrover1 @andersy005