Capgen in SCM: Fix to allow for scheme subcycling. #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinswales
requested review from
climbfuji,
gold2718,
mwaxmonsky,
peverwhee,
grantfirl and
mkavulich
as code owners
dustinswales
changed the title
climbfuji
reviewed
Jan 29, 2025
| if gen_unique: | ||
| new_lname = self.new_internal_variable_name(prefix=lname) | ||
| newvar = newvar.clone(new_lname) | ||
| # Local_name needs to be the local_name for the new |
There was a problem hiding this comment.
I am very confused by this comment. Should the first Local_name be lname?
There was a problem hiding this comment.
All instances of lname are replaced, there is no logic to keep the first instance. So for three instances of the same lname, we have lname1, lname2, and lname3, not lname, lname1, lname2.
There was a problem hiding this comment.
Also, this is part of #631 and does not impact the sub-cycling isssue
… bugfix/scheme_subcycling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR contains changes to fix scheme subcycing in Capgen and extends the var_compatability_test to exercise subcycling.
UPDATE: Added bugfix for suite-part list ordering.
Description
Create local group variable for subcycle indexing.
Fix bug (
self.loop->self._loop) in the Subcycle write phase, and in ccpp_datafile.User interface changes?: No
Fixes: #632
Fixes: #634
Testing:
Added to var_compatibility_test to exercise feature.
This PR contains changes in #631