Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove register for dart link because this no longer exists #617

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

hkershaw-brown
Copy link
Member

remove register for dart link because this no longer exists:

  • README.md
  • models/wrf/tutorial/README.rst

Added Apache license badge to README.md

Description:

Please provide a summary of the change and include any relevant motivation and context.

Fixes issue

Fixes #616 if you ignore the header in every file.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Built docs with sphinx locally.
Previewed README.md with macdown.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

see #616
Added Apache license badge to README.md
@hkershaw-brown hkershaw-brown added the release! bundle with next release label Jan 8, 2024
Copy link
Contributor

@ann-norcio ann-norcio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation changes look good

Copy link
Contributor

@mjs2369 mjs2369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Approved

@hkershaw-brown hkershaw-brown merged commit fc03f7c into main Jan 9, 2024
4 checks passed
@hkershaw-brown hkershaw-brown deleted the remove-register branch January 9, 2024 18:26
@mjs2369 mjs2369 mentioned this pull request Sep 30, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release! bundle with next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DART registration link no longer exists and is in every file.
3 participants