Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BKJ quantile methods edit #612

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

johnsonbk
Copy link
Collaborator

@johnsonbk johnsonbk commented Jan 4, 2024

Description:

Documentation

Fixes issue

Reconciles comments made on the quantile methods pull request, which is PR five-eighty-eight #588. I'm avoiding referencing that PR with an Arabic numeral because I don't want the approval of this pull request to interfere with that one. However, merging this pull request should resolve the comments I made on five-eighty-eight.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Ran make html using Sphinx to test each of the changes to the documentation.

Worked through the four examples in guide/qceff-examples.rst and plotted their output with diagnostics/matlab/plot_ens_time_series.m

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@hkershaw-brown hkershaw-brown requested a review from jlaucar January 5, 2024 00:01
@hkershaw-brown hkershaw-brown merged commit 3773782 into quantile_methods Jan 5, 2024
4 checks passed
@hkershaw-brown hkershaw-brown deleted the bkj_quantile_methods_edit branch January 5, 2024 14:17
@hkershaw-brown hkershaw-brown mentioned this pull request Jan 5, 2024
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants