Eliminate amp adjustment #604
Merged
+8
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…legacy bit of code that was required to bitwise reproduce earlier versions. About half of ensemble sizes continue to bitwise reproduce with this change using Jeff's lorenz96_tracer_mod tests. For the others, the amp_adj was different from 1 at the smallest writeable decimal point and the tests ran producing reasonable, but no longer backward compatible, results.
hkershaw-brown
requested changes
Dec 18, 2023
There was a problem hiding this comment.
looks good Jeff. You still have amp_adj in the declarations for inv_bnrh_cdf. You can take that out since amp_adj is not in the subroutine anymore
-real(r8) :: q(ens_size), curr_q, lower_q, upper_q, del_q, fract, amp_adj
+real(r8) :: q(ens_size), curr_q, lower_q, upper_q, del_q, fract
|
Helen,
I removed this, tested a compile, committed and pushed. I didn't like the
message I got from the push so not sure if it worked or if I need to update
the pull request in any other way. Please let me know if there are
problems.
…On Mon, Dec 18, 2023 at 11:54 AM Helen Kershaw ***@***.***> wrote:
***@***.**** requested changes on this pull request.
looks good Jeff. You still have amp_adj in the declarations for
inv_bnrh_cdf. You can take that out since amp_adj is not in the subroutine
anymore
-real(r8) :: q(ens_size), curr_q, lower_q, upper_q, del_q, fract, amp_adj
+real(r8) :: q(ens_size), curr_q, lower_q, upper_q, del_q, fract
—
Reply to this email directly, view it on GitHub
<#604 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDHUIXVFLVSZ2VTN5VDXG3YKCGQFAVCNFSM6AAAAABAZ4QLK6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOBXGUZDKOBUGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Removed an amplitude adjustment factor from inv_bnrh_cdf. This was a legacy bit of code
that was required to bitwise reproduce earlier versions. About half of ensemble sizes
continue to bitwise reproduce with this change using Jeff's lorenz96_tracer_mod tests.
For the others, the amp_adj was different from 1 at the smallest writeable decimal
point and the tests ran producing reasonable, but no longer backward compatible,
results.
Fixes issue
Types of changes
Documentation changes needed?
Tests
See description.
Checklist for merging
Checklist for release
Testing Datasets