fix print of number of obs converted, and make input.nml defaults better #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tter the convert_airs_L2 converter was printing 1 more obs converted than was actually done. also, the settings for the convert_airs_L2 namelist thinned out all the obs. change the defaults to include all possible obs.
|
p.s. i linked this with the original hdf-eos library and got the 'file not found' error. i linked it with the hdf-eos.patch version of the library and it ran fine. |
hkershaw-brown
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Approved! thanks @nancycollins
@hkershaw-brown @mjs2369 bundle with next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the convert_airs_L2 converter was printing 1 more obs converted than was actually done.
also, the settings for the convert_airs_L2 namelist thinned out all the obs. change the defaults to include all possible obs, including all latitudes, and give an example filename for input instead of a list name. the input file isn't in our repo, but it might help a user see what kind of filename they're looking for.
Description:
fix printout of number of obs converted to be right.
also change namelist defaults to not thin out all obs
Fixes issue
fixes #596
Types of changes
Documentation changes needed?
Tests
i built and ran this with my copy of the updated HDF_EOS libraries and it printed out the correct number of obs. it also didn't thin them all out.
Checklist for merging
Checklist for release
Testing Datasets