Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions mpif08 check #576

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Github Actions mpif08 check #576

merged 4 commits into from
Nov 9, 2023

Conversation

mjs2369
Copy link
Contributor

@mjs2369 mjs2369 commented Nov 9, 2023

Description:

Adds a new check to the Github Actions workflow that uses the mpif08 module (compiles with ./quickbuild mpif08 and runs filter on 2 mpi tasks with the lorenz_96 model).

This allows for the automatic testing of the mpif08 module when triggered by a new pull request and/or updates to a pull request.

There are now three total checks in our Actions workflow (build-run-lorenz_96-mpi, build-run-lorenz_63-nompi, build-run-lorenz_96-mpif08)

Fixes issue

fixes #563

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Tested on my fork of DART by using a mock pull request to run the three total checks. All pass successfully and use the correct modules/input options.

mjs2369#1

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

…, mpi, and mpif08. Updating the conditionals in the runs to accomodate for mpif08
Copy link
Member

@hkershaw-brown hkershaw-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Marlee.
Runs all the cases.
@mjs2369 do you want to go ahead and tag and release?

@mjs2369 mjs2369 merged commit 8fcd47d into main Nov 9, 2023
@mjs2369 mjs2369 deleted the actions_mpif08 branch November 9, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: mpif08 github action on pull request
2 participants