Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QCEFF Table #545

Closed
wants to merge 62 commits into from
Closed

QCEFF Table #545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
ef152a1
draft program to experiment with reading table values into correspond…
Aug 14, 2023
ebdbf31
prototype table data file that uses CAM-FV QTYs
Aug 14, 2023
262965b
adding new subroutine init_qcf_table to return number of rows in table
Aug 14, 2023
715875d
Adding a new namelist variable to the assim_tools_nml
Aug 14, 2023
1f9dcc3
Adding QCF table type definitions to algorithm_info_mod
Aug 14, 2023
e8ff87f
adding type defs to use statement for algorithm_info_mod in assim_too…
Aug 14, 2023
7024e2b
Adding allocatable variables for table data, allocating after determi…
Aug 14, 2023
935bcb5
New subroutine to read through the values in the QCF table and assign…
Aug 14, 2023
be4ee63
Removing qcf table data types from assim_tools_mod and reorganizing s…
Aug 14, 2023
66356a6
Fixing small inconsistencies/typos
Aug 14, 2023
b62339e
moving the location of draft program outside /assimilation_code/modul…
Aug 14, 2023
7659472
Adding draft subroutine write_qcf_table to test that values are being…
Aug 15, 2023
e995563
replaicing conditionals and hardcoded values in probit_dist_info
Aug 15, 2023
fa514c2
using get_name_for_quantity to get generic quantity from integer index
Aug 16, 2023
f291025
Replacing conditionals and hard coded values with qcf_table_data in o…
Aug 16, 2023
5a26816
Replacing conditionals and hard coded values with qcf_table_data in o…
Aug 16, 2023
2376bbc
add subroutine to deallocate qcf table data structures
Aug 16, 2023
90c9beb
making dealloc subroutine available to assim_tools_mod
Aug 17, 2023
b1c0658
Merge branch 'quantile_methods' of https://github.com/NCAR/DART into …
Aug 17, 2023
6de99ba
removing comment blocks of old code
Aug 17, 2023
c5e0eb1
Adding call to deallocate routine, removing unused var and old commen…
Aug 21, 2023
d61382e
Fixing typo in subroutine names
Aug 21, 2023
e842a2b
Moving the allocation and deallocation of qcf table data from assim_t…
Aug 22, 2023
a78be83
uncommenting call to end_alg_info_mod
Aug 22, 2023
dc0c617
moving call to init_algortihm_info_mod out of conditional
Aug 23, 2023
2d6808e
Reorganizing the subroutines so that init_algorithm_info_mod is at th…
Aug 23, 2023
19b6150
Adding qcf_table_listed logical and module_initialized checks
Aug 23, 2023
efa929b
Moving location of qcf_table_listed check to before data access from …
Aug 23, 2023
16354ab
Using error_handler from utilities_mod; adding check for correct tabl…
Aug 28, 2023
8595523
adding qcf_table_file_listed logical to two remaining subrountines; w…
Sep 5, 2023
e3f3131
commenting out prints; remove these lines later
Sep 5, 2023
05c5fff
Moving initialize_modules call to be after read of filter_nml
Sep 11, 2023
2719226
Adding check that all QTYs in the table exist in DART using get_index…
Sep 11, 2023
8f79b3c
Replacing open and close of qcf_table file with open_file and close_f…
Sep 11, 2023
c0b00e0
Making quotations consistent - using single quote only
Sep 11, 2023
0ace5e9
Adding checks for duplicate QTYs in the table
Sep 12, 2023
b32ac93
Switching to real(r8); experimenting in the log_qcf_table subroutine
Sep 13, 2023
1c5cfa4
reading in character strings from QCF table for filter_kind instead o…
Sep 13, 2023
844a811
Reading in dist_type from the table as a character string instead of int
Sep 14, 2023
5ebb793
Fixing log format; cleaning code
Sep 19, 2023
8eed1d8
Merge branch 'quantile_methods' of https://github.com/NCAR/DART into …
Sep 25, 2023
2be50ef
Removing unnecessary files
Sep 25, 2023
399b62b
Adding the yaml_to_table.py script and example yaml file qcf_table_te…
Sep 25, 2023
1911ed0
Fixing deallocation by adding conditional to check if data types were…
Sep 25, 2023
41ffe95
Adjusting the YAML template file; removing trailing spaces from possi…
Sep 25, 2023
f5fa29b
Adding documentaion file to repo
Sep 25, 2023
b37cf76
Removing unused routines from utilities_mod use list
Sep 26, 2023
6681875
Adding &probit_transform_nml to input.nml files for lorenz 63 and 96 …
Sep 26, 2023
3e39cf2
Removing the use_algorithm_info_mod logical from assim_tools_mod and …
Sep 26, 2023
80305c7
Fixing unintentional additions to lorenx 96 and 63 input.nml files; r…
Sep 26, 2023
eb38d48
Adding spaces back in from unintentional removal
Sep 26, 2023
528e162
Adding &probit_transform_nml and qcf_table_filename option to model's…
Sep 26, 2023
caf5dac
Fixing missing commas in nml files
Sep 27, 2023
c184e90
add test cases for reading qcf table
hkershaw-brown Sep 28, 2023
2e07008
test script to check return codes for various qcf_table cases
hkershaw-brown Sep 28, 2023
200a8f4
remove stray /dev/null left in accidentally
hkershaw-brown Sep 28, 2023
46f238f
add tests for various bounds options
hkershaw-brown Sep 28, 2023
ca99e8b
test for bounds set to false, but bounds values in the table
hkershaw-brown Sep 28, 2023
22f86c4
fix: need to check that a qty is bounded above and below before check…
hkershaw-brown Sep 29, 2023
38353bb
fix: remove extra call to test_table read from runall.sh
hkershaw-brown Sep 29, 2023
a4723e7
replace kind with qty
hkershaw-brown Oct 2, 2023
bd4dbab
add two tests for table read: incorrect filter kind, incorrect distri…
hkershaw-brown Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ stacktest
obs_rwtest
test_quad_irreg_interp
test_quad_reg_interp
test_table_read

# Directories to NOT IGNORE ... same as executable names
# as far as I know, these must be listed after the executables
Expand Down
Loading