Fix different vertical level conflict when plotting Tape Recorder #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove this code because if the cases have different number of vertical levels, then the concat datasets will cause problems (they will combine the levels into the new lev dim).
```python
#Check to see if any cases were successful
if runname_LT:
runname_LT=xr.DataArray(runname_LT, dims='run', coords=[np.arange(0,len(runname_LT),1)], name='run')
```
Also clean up code for readability, and change data read in (plus CESM time fix) to new data class method.
justin-richling
changed the title
justin-richling
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @cecilehannay pointed out in #301, in the Tape Recorder plot, if the test cases have different vertical levels the plots get messed up. This fix will remove this code
because the
xr.concatdatasets is what is causing the problems. They will combine the levels of all cases into the new lev dim, ie case1 has 70 levels and case2 has 93 levels, the finalxr.concat(alldat, dim=runname_LT)will cause the 'lev' dim to be 163.Also clean up code for readability, and change data read in (plus CESM time fix) to new data class method.
Closes #301