Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make search also return Project info #858

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

jonandernovella
Copy link
Contributor

@jonandernovella jonandernovella commented Sep 13, 2023

This solves the existing bug when you search for issues based on normal text instead of issue ids.

Related issue(s) and PR(s)

This PR closes #857

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • Make search endpoint also return project info
  • Handle new project info accordingly in the urdr proxy

Testing

  • In quick search, search for GDI and select an issue
  • Run the unit tests

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

This solves the existing bug when you search based on normal text instead of issue ids.
Copy link
Member

@kusalananda kusalananda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@kusalananda kusalananda merged commit 4ef14ad into develop Sep 13, 2023
7 checks passed
@kusalananda kusalananda deleted the hotfix/search-activities branch September 13, 2023 09:34
@jonandernovella jonandernovella mentioned this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The seach interface is broken for text searches
2 participants