Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow and test asteroids with A/ designations. #343

Merged

Conversation

mkelley
Copy link
Member

@mkelley mkelley commented Jun 4, 2022

Addresses #340

@pep8speaks
Copy link

pep8speaks commented Jun 4, 2022

Hello @mkelley! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 452:80: E501 line too long (80 > 79 characters)

Comment last updated at 2022-07-06 13:13:14 UTC

@mkelley mkelley force-pushed the data-names-add-a-slash-2022.06 branch from 4647e9d to 5313844 Compare June 27, 2022 16:17
@jianyangli jianyangli linked an issue Jun 29, 2022 that may be closed by this pull request
@jianyangli jianyangli self-requested a review June 29, 2022 21:04
@jianyangli jianyangli force-pushed the data-names-add-a-slash-2022.06 branch from 5313844 to 5685a56 Compare June 29, 2022 21:04
Copy link
Contributor

@jianyangli jianyangli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mkelley , I just left a few comments and rebased this branch to bring it up to date with the main. Hope that's fine with you.

sbpy/data/names.py Show resolved Hide resolved
sbpy/data/names.py Outdated Show resolved Hide resolved
sbpy/data/names.py Show resolved Hide resolved
Copy link
Contributor

@jianyangli jianyangli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mkelley mkelley merged commit b55bd85 into NASA-Planetary-Science:main Jul 6, 2022
@mkelley mkelley deleted the data-names-add-a-slash-2022.06 branch July 6, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A/ designations do not parse
3 participants