TilesRendererBase url constructor parameter should be optional (#812

) * URL should be optional * update Google examples
NASA-AMMOS · Oct 17, 2024 · 76d4473 · 76d4473
1 parent 82884e1
commit 76d4473
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/example/googleMapsAerial.js b/example/googleMapsAerial.js
@@ -1,4 +1,4 @@
-import { GeoUtils, WGS84_ELLIPSOID, GooglePhotorealisticTilesRenderer, GoogleCloudAuthPlugin } from '../src/index.js';
+import { GeoUtils, WGS84_ELLIPSOID, TilesRenderer, GoogleCloudAuthPlugin } from '../src/index.js';
 import {
 	Scene,
 	WebGLRenderer,
@@ -42,7 +42,7 @@ function reinstantiateTiles() {
 
 	}
 
-	tiles = new GooglePhotorealisticTilesRenderer();
+	tiles = new TilesRenderer();
 	tiles.registerPlugin( new GoogleCloudAuthPlugin( { apiToken: params.apiKey } ) );
 	tiles.registerPlugin( new TileCompressionPlugin() );
 	tiles.registerPlugin( new TilesFadePlugin() );

diff --git a/example/googleMapsExample.js b/example/googleMapsExample.js
@@ -3,7 +3,7 @@ import {
 	CAMERA_FRAME,
 	GeoUtils,
 	GlobeControls,
-	GooglePhotorealisticTilesRenderer,
+	TilesRenderer,
 	GoogleCloudAuthPlugin,
 } from '../src/index.js';
 import {
@@ -55,7 +55,7 @@ function reinstantiateTiles() {
 
 	localStorage.setItem( 'googleApiKey', params.apiKey );
 
-	tiles = new GooglePhotorealisticTilesRenderer();
+	tiles = new TilesRenderer();
 	tiles.registerPlugin( new GoogleCloudAuthPlugin( { apiToken: params.apiKey, autoRefreshToken: true } ) );
 	tiles.registerPlugin( new TileCompressionPlugin() );
 	tiles.registerPlugin( new UpdateOnChangePlugin() );

diff --git a/src/base/TilesRendererBase.d.ts b/src/base/TilesRendererBase.d.ts
@@ -18,7 +18,7 @@ export class TilesRendererBase {
 	parseQueue : PriorityQueue;
 	downloadQueue : PriorityQueue;
 
-	constructor( url : String );
+	constructor( url?: String );
 	update() : void;
 	registerPlugin( plugin: Object ) : void;
 	unregisterPlugin( plugin: Object | String ) : Boolean;