Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove proxy app #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove proxy app #114

wants to merge 1 commit into from

Conversation

hsiaoyi0504
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Mar 14, 2018

Coverage Status

Coverage decreased (-0.04%) to 40.128% when pulling cf5eb38 on remove_proxy into 298bff7 on master.

@codecov
Copy link

codecov bot commented Mar 14, 2018

Codecov Report

Merging #114 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   47.64%   47.81%   +0.17%     
==========================================
  Files          69       66       -3     
  Lines        3480     3455      -25     
==========================================
- Hits         1658     1652       -6     
+ Misses       1822     1803      -19
Impacted Files Coverage Δ
i5k/urls.py 100% <ø> (ø) ⬆️
i5k/settings.py 93.33% <ø> (ø) ⬆️
blast/views.py 71.91% <0%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 298bff7...cf5eb38. Read the comment docs.

@childers
Copy link
Contributor

I think that the new version of apollo will be fine, but am not sure if the older instances will lose the GO function if this is removed. We may need to wait until migration is finished.

@childers childers added the On Hold For Now Ready for merge, but do not merge yet. label Mar 29, 2018
@childers childers requested a review from ifishlin April 9, 2018 14:25
Copy link
Contributor

@ifishlin ifishlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good

@hsiaoyi0504
Copy link
Member Author

Finished rebase for #151. On hold until the transition to apollo 2 finished.

@childers
Copy link
Contributor

Confirmed that Apollo2 does not need this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Hold For Now Ready for merge, but do not merge yet. wait for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants