Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add CI jobs #70

Merged
merged 10 commits into from
Jun 18, 2024
Merged

chore: add CI jobs #70

merged 10 commits into from
Jun 18, 2024

Conversation

giac-mysten
Copy link
Collaborator

Contributes to: #42

@giac-mysten giac-mysten force-pushed the gg/ci-and-docs branch 2 times, most recently from 8a8eebe to 6813fc4 Compare June 17, 2024 17:28
@giac-mysten
chore: add lint workflow
e980fb6 
Signed-off-by: giac-mysten <[email protected]>
@giac-mysten giac-mysten requested a review from mlegner June 17, 2024 18:21
@giac-mysten
Copy link
Collaborator Author

giac-mysten commented Jun 17, 2024 •
edited
Loading

@mlegner could you take a quick look to code.yml, lint.yml, pre-commit-config and especially the allow lists in deny.toml when you have a moment tomorrow? I hope I didn't butcher them too much .

Also, is Unicode-3.0 fine as a license?

@mlegner
Copy link
Collaborator

mlegner commented Jun 18, 2024

Also, is Unicode-3.0 fine as a license?

I would say probably yes. Seems to be a permissive license similar to MIT. But of course, I'm not a legal expert. 🤷

mlegner
mlegner approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't go through everything in detail as I assume it's mostly copied from our other repos. Everything looks good, just a few minor comments.

.github/workflows/code.yml Show resolved Hide resolved
deny.toml Show resolved Hide resolved
CODE_OF_CONDUCT.md Show resolved Hide resolved
site-builder/src/walrus.rs Show resolved Hide resolved
Cargo.lock Show resolved Hide resolved
@giac-mysten giac-mysten merged commit 5c3b7d5 into main Jun 18, 2024
12 checks passed
@giac-mysten giac-mysten deleted the gg/ci-and-docs branch June 18, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlegner mlegner mlegner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giac-mysten @mlegner