Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common-lib): derive routes df instead of fetch #337

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

Tzal3x
Copy link
Collaborator

@Tzal3x Tzal3x commented Dec 24, 2024

This change will save us from doing one additional request each time we need to fetch the Routes dynamic field.

It derives the dynamic field object ID of Routes instead of fetching it.

@Tzal3x Tzal3x self-assigned this Dec 24, 2024
Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
walrus-sites-sp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 10:25am
walrus-sites-sp-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 10:25am
walrus-sites-sw-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 10:25am

Copy link

codspeed-hq bot commented Dec 24, 2024

CodSpeed Performance Report

Merging #337 will not alter performance

Comparing alextzimas/derive-routes-df-instead-of-fetch-2 (a8028d5) with main (8719f8f)

Summary

✅ 3 untouched benchmarks

Copy link
Collaborator

@giac-mysten giac-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you @Tzal3x !

portal/common/lib/routing.ts Show resolved Hide resolved
@Tzal3x Tzal3x merged commit 1b59b85 into main Jan 7, 2025
21 checks passed
@Tzal3x Tzal3x deleted the alextzimas/derive-routes-df-instead-of-fetch-2 branch January 7, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants