Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(site-builder):SEINT-275 Add http headers default cache-control to public, max-age=3600 #333

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(site-builder):SEINT-275 Add http headers default cache-control to public, max-age=3600 #333

wants to merge 1 commit into from

Conversation

VLegakis
Copy link

No description provided.

@VLegakis VLegakis self-assigned this Dec 18, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
walrus-sites-sp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 5:46pm
walrus-sites-sp-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 5:46pm
walrus-sites-sw ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 5:46pm
walrus-sites-sw-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 5:46pm

@VLegakis VLegakis changed the title Add http headers default cache-control to public, max-age=3600 SEINT-275 Add http headers default cache-control to public, max-age=3600 Dec 18, 2024
@VLegakis VLegakis changed the title SEINT-275 Add http headers default cache-control to public, max-age=3600 feat(site-builder):SEINT-275 Add http headers default cache-control to public, max-age=3600 Dec 18, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 18, 2024

CodSpeed Performance Report

Merging #333 will not alter performance

Comparing vl/SEINT-275-caching (80db847) with main (7899e4b)

Summary

✅ 3 untouched benchmarks

@VLegakis
Copy link
Author

After discussion with @Tzal3x we decided to leave this default cache-control policy for the future. Lets leave this PR open-pending and we decide depending on the type of sites being published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VLegakis VLegakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VLegakis