Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat(site-builder): add permanent flag in site-builder publish command #320

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

VLegakis
Copy link

@VLegakis VLegakis commented Dec 6, 2024

site-builder delete command needs to be added.

@VLegakis VLegakis requested a review from Tzal3x December 6, 2024 21:29
@VLegakis VLegakis self-assigned this Dec 6, 2024
Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
walrus-sites-sp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 7:22pm
walrus-sites-sp-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 7:22pm
walrus-sites-sw ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 7:22pm
walrus-sites-sw-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 7:22pm

Copy link

codspeed-hq bot commented Dec 6, 2024

CodSpeed Performance Report

Merging #320 will not alter performance

Comparing SEINT-228-deletable-blobs (ac951ea) with main (f83a9c4)

Summary

✅ 3 untouched benchmarks

Copy link
Collaborator

@Tzal3x Tzal3x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the project @VLegakis!
Despite this being still a WIP, here is an early comment:
Regarding deletable sites in walrus, based on this discussion, we might need the opposite of what is implemented currently.
i.e. instead of publishing sites as deletable with a --deletable flag, we should always publish them as deletable by default, unless specified otherwise with --permanent.

Though they are not exactly permanent, as they will still get deleted when their epoch expires.

@giac-mysten do you think --only-expirable instead of --permanent would better depict the actual site lifetime being set?

@Tzal3x
Copy link
Collaborator

Tzal3x commented Dec 7, 2024

Also, please check out CONTRIBUTING.md and follow how to set your .editorconfig in order to automatically resolve lint errors like it's happening now.

@giac-mysten
Copy link
Collaborator

@giac-mysten do you think --only-expirable instead of --permanent would better depict the actual site lifetime being set?

@Tzal3x good question. "Permanent" is official Walrus terminology. When you walrus store <FILE>, the output says "Success: Permanent blob stored successfully."

So i'd say --permanent is fine.

@VLegakis VLegakis changed the title WIP: Add deletable flag in warlus store assets upload WIP: feat(site-builder): add permanent flag in site-builder publish command Dec 9, 2024
@VLegakis VLegakis changed the title WIP: feat(site-builder): add permanent flag in site-builder publish command feat(site-builder): add permanent flag in site-builder publish command Dec 9, 2024
@VLegakis VLegakis changed the title feat(site-builder): add permanent flag in site-builder publish command WIP: feat(site-builder): add permanent flag in site-builder publish command Dec 9, 2024
@VLegakis VLegakis changed the title WIP: feat(site-builder): add permanent flag in site-builder publish command feat(site-builder): add permanent flag in site-builder publish command Dec 9, 2024
@VLegakis VLegakis marked this pull request as draft December 12, 2024 09:34
Base automatically changed from gg/site-builder/update-package-and-burn to main December 12, 2024 16:35
@VLegakis VLegakis removed the request for review from giac-mysten December 12, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants