Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ops): add move-tests github action and improve test coverage #310

Merged
merged 8 commits into from
Dec 5, 2024

Conversation

Tzal3x
Copy link
Collaborator

@Tzal3x Tzal3x commented Nov 29, 2024

  • new github action: downloads the sui binary, runs the tests and also checks if there is enough test coverage.
  • new tests in the contract: increases test coverage in order to reach at least 80%.

Downloads the sui binary,
runs the tests and also checks
if there is enough test coverage.
@Tzal3x Tzal3x self-assigned this Nov 29, 2024
Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
walrus-sites-sp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 0:43am
walrus-sites-sp-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 0:43am
walrus-sites-sw ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 0:43am
walrus-sites-sw-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 0:43am

@Tzal3x Tzal3x added the ops label Nov 29, 2024
Copy link

codspeed-hq bot commented Nov 29, 2024

CodSpeed Performance Report

Merging #310 will not alter performance

Comparing ta/add-move-tests-github-action (a3a1b07) with main (aadb7ba)

Summary

✅ 3 untouched benchmarks

@Tzal3x Tzal3x changed the title feat(ops): add move-tests github action feat(ops): add move-tests github action and improve test coverage Nov 29, 2024
Copy link
Collaborator

@giac-mysten giac-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thanks for improving test coverage

move/walrus_site/tests/site_tests.move Show resolved Hide resolved
@Tzal3x Tzal3x merged commit 4d1e19e into main Dec 5, 2024
21 checks passed
@Tzal3x Tzal3x deleted the ta/add-move-tests-github-action branch December 5, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants