fix: add check that suins name has not changed to cache #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: giac-mysten <[email protected]>
Signed-off-by: giac-mysten <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: giac-mysten <[email protected]>
|
@Tzal3x merging now w/o review to speed up testing. Please feel free to open another PR from this commit to add comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache was not checking that the suins name for a site had not been changed.
Therefore, if it was changed, the cache would not refresh.
The changes are a bit ugly and painful. I think it's soon going to be time to sit down and and improve the architecture of the worker and library.