feat(common-lib): derive dynamic field instead of call to fullnode #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Tzal3x
changed the title
CodSpeed Performance ReportMerging #246 will not alter performanceComparing Summary
Benchmarks breakdown
|
Tzal3x
force-pushed
the
240-construct-manually-the-object-id-of-the-dynamic-field-without-needing-to-request-it-from-the-rpc
branch
from
965321f
to
2af5519
Compare
This version includes the deriveDynamicFieldID function needed to calculate the DF object ID without making a request to a fullnode.
Tzal3x
force-pushed
the
240-construct-manually-the-object-id-of-the-dynamic-field-without-needing-to-request-it-from-the-rpc
branch
from
2af5519
to
c7ee62d
Compare
test name: "should return NOT_FOUND if dynamic fields are not found"
Open
1 task
giac-mysten
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Awesome, thanks @Tzal3x . Generally looks good, only one more important comment.
giac-mysten
deleted the
240-construct-manually-the-object-id-of-the-dynamic-field-without-needing-to-request-it-from-the-rpc
branch
giac-mysten
pushed a commit
that referenced
this pull request
Oct 16, 2024
) - Upgrade @mysten/sui to 1.12.0 This version includes the `deriveDynamicFieldID` function needed to calculate the DF object ID without making a request to a fullnode. - Replace `client.getDynamicFieldObject` with `deriveDynamicFieldID`. - Skip `page_fetching` benchmarks. The results we get from it are misleading and slow down development whenever there are changes happening in its' dependencies. In the near future we should revisit how to properly bench this. #250 TODO (following PR) - ⚡ Performance improvement: Use `multiGetObjects` to fetch both the display and the dynamic field object in the same request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version includes the
deriveDynamicFieldIDfunction needed to calculate the DF object ID
without making a request to a fullnode.
client.getDynamicFieldObjectwithderiveDynamicFieldID.page_fetchingbenchmarks. The results we get from it are misleading and slow down development whenever there are changes happening in its' dependencies. In the near future we should revisit how to properly bench this. Use multiGetObjects to fetch both the display and the dynamic field object in the same request #250TODO (following PR)
multiGetObjectsto fetch both the display and the dynamic field object in the same request.