Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(portal): add caching interface to sw portal routing #236

Draft
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

Tzal3x
Copy link
Collaborator

@Tzal3x Tzal3x commented Oct 8, 2024

Adds caching to the routing logic.

  • Implement the routing cache interface for the service worker portal
  • Implement the routing cache interface for the server portal

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
walrus-sites-sp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 0:47am
walrus-sites-sw ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 0:47am

@Tzal3x Tzal3x self-assigned this Oct 8, 2024
Copy link

codspeed-hq bot commented Oct 8, 2024

CodSpeed Performance Report

Merging #236 will degrade performances by 58.49%

Comparing 220-add-caching-interface-to-portal-routing (2b60e6d) with 220-integrate-routing-to-portal (e86a2b6)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 5 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark 220-integrate-routing-to-portal 220-add-caching-interface-to-portal-routing Change
decompress plaintext encoding 18 µs 15.9 µs +13.76%
fetchPage: should successfully fetch the mocked landing page site 9.2 ms 22.1 ms -58.49%

@Tzal3x Tzal3x force-pushed the 220-add-caching-interface-to-portal-routing branch from de8d1c4 to 6c01780 Compare October 9, 2024 08:57
@Tzal3x
Copy link
Collaborator Author

Tzal3x commented Oct 10, 2024

Open questions:

  • Expiration date.
  • Update Routes when ws-resources.json changes.
  • Does a new db get created for every walrus site? If so, can we avoid it and use the same index/schema for all?

@Tzal3x Tzal3x marked this pull request as draft October 10, 2024 13:55
Base automatically changed from 220-integrate-routing-to-portal to develop October 11, 2024 07:36
@Tzal3x Tzal3x changed the title feat(portal): add caching interface to portal routing feat(portal): add caching interface to sw portal routing Oct 14, 2024
@Tzal3x Tzal3x mentioned this pull request Oct 18, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support path prefix matching for client-side routing
2 participants