Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use multiGetObjects to fetch both the display and the dynamic field object in the same request #250

Open
1 task done
Tzal3x opened this issue Oct 15, 2024 · 0 comments · May be fixed by #270
Open
1 task done

Use multiGetObjects to fetch both the display and the dynamic field object in the same request #250

Tzal3x opened this issue Oct 15, 2024 · 0 comments · May be fixed by #270
Assignees
@Tzal3x
Labels
common-library performance

Comments

@Tzal3x
Copy link
Collaborator

Tzal3x commented Oct 15, 2024

Description

Since we can derive the dynamic field object id instead of requesting it from a full node,
we can get details about it in the same request that we parse the Display object from the parent (site) object.

i.e. include the getObject of checkRedirect and the getObject({options: bcs, display ...}) in the same multiGetObjects clause.

Related to #246

Component

portal

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@Tzal3x Tzal3x mentioned this issue Oct 15, 2024
Merged
@Tzal3x Tzal3x self-assigned this Oct 15, 2024
giac-mysten pushed a commit that referenced this issue Oct 15, 2024
@Tzal3x
feat(common-lib): derive dynamic field instead of call to fullnode (#246
6bcc382 
)

- Upgrade @mysten/sui to 1.12.0
This version includes the `deriveDynamicFieldID`
function needed to calculate the DF object ID
without making a request to a fullnode.
- Replace `client.getDynamicFieldObject` with `deriveDynamicFieldID`.
- Skip `page_fetching` benchmarks. The results we get from it are
misleading and slow down development whenever there are changes
happening in its' dependencies. In the near future we should revisit how
to properly bench this.
#250

TODO (following PR)
- ⚡ Performance improvement: Use `multiGetObjects` to fetch both the
display and the dynamic field object in the same request.
giac-mysten pushed a commit that referenced this issue Oct 16, 2024
@Tzal3x @giac-mysten
feat(common-lib): derive dynamic field instead of call to fullnode (#246
36631dc 
)

- Upgrade @mysten/sui to 1.12.0
This version includes the `deriveDynamicFieldID`
function needed to calculate the DF object ID
without making a request to a fullnode.
- Replace `client.getDynamicFieldObject` with `deriveDynamicFieldID`.
- Skip `page_fetching` benchmarks. The results we get from it are
misleading and slow down development whenever there are changes
happening in its' dependencies. In the near future we should revisit how
to properly bench this.
#250

TODO (following PR)
- ⚡ Performance improvement: Use `multiGetObjects` to fetch both the
display and the dynamic field object in the same request.
@Tzal3x Tzal3x linked a pull request Oct 21, 2024 that will close this issue
perf: replace getObject for pageData with multiGetObjects #270
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tzal3x Tzal3x

Labels
common-library performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: replace getObject for pageData with multiGetObjects MystenLabs/walrus-sites
1 participant
@Tzal3x