[Payments V2] Discount House Revamp #220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leecchh
approved these changes
Dec 2, 2024
manolisliolios
changed the title
manolisliolios
force-pushed
the
ml/discount-house-revamp
branch
from
16a1274 to
2dd5735
Compare
0xaslan
reviewed
Jan 9, 2025
| public fun assert_version_is_valid(self: &DiscountHouse) { | ||
| assert!(self.version == VERSION, ENotValidVersion); | ||
| public(package) macro fun discount_house_key(): String { | ||
| b"object_discount".to_string() |
There was a problem hiding this comment.
I don't feel strongly between making this a constant or returning the string directly cc: @manolisliolios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamp the Discount House (object-based discount) for both free claims & percentage off sales to use the new payments design, simplifying the process.