Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[consensus] Include links to partially propagated blocks from excluded ancestors #20845

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[consensus] Include links to partially propagated blocks from excluded ancestors #20845

wants to merge 2 commits into from
+165 −31

Conversation

arun-koshy
Copy link
Contributor

Test plan

Pending tests on private-testnet

@arun-koshy arun-koshy requested review from akichidis and mwtian January 9, 2025 23:20
@vercel Vercel
Copy link

vercel bot commented Jan 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 9:10pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 9:10pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 9:10pm

@arun-koshy arun-koshy temporarily deployed to sui-typescript-aws-kms-test-env January 9, 2025 23:20 — with GitHub Actions Inactive
@arun-koshy arun-koshy requested a review from a team as a code owner January 9, 2025 23:21
@arun-koshy arun-koshy temporarily deployed to sui-typescript-aws-kms-test-env January 9, 2025 23:21 — with GitHub Actions Inactive
@mwtian mwtian changed the title [consensus] Include weak links of excluded ancestors [consensus] Include links to partially propagated blocks from excluded ancestors Jan 10, 2025
mwtian
mwtian reviewed Jan 10, 2025
View reviewed changes
consensus/core/src/core.rs Outdated Show resolved Hide resolved
consensus/core/src/core.rs Outdated Show resolved Hide resolved
consensus/core/src/core.rs Outdated Show resolved Hide resolved
@mwtian mwtian temporarily deployed to sui-typescript-aws-kms-test-env January 10, 2025 17:58 — with GitHub Actions Inactive
@mwtian mwtian temporarily deployed to sui-typescript-aws-kms-test-env January 10, 2025 18:09 — with GitHub Actions Inactive
@mwtian mwtian temporarily deployed to sui-typescript-aws-kms-test-env January 10, 2025 19:52 — with GitHub Actions Inactive
arun-koshy
arun-koshy commented Jan 10, 2025
View reviewed changes
consensus/core/src/core.rs Outdated Show resolved Hide resolved
consensus/core/src/dag_state.rs Outdated Show resolved Hide resolved
@mwtian mwtian temporarily deployed to sui-typescript-aws-kms-test-env January 10, 2025 21:08 — with GitHub Actions Inactive
mwtian
mwtian approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@mwtian mwtian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try this on PT first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwtian mwtian mwtian approved these changes

@akichidis akichidis Awaiting requested review from akichidis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arun-koshy @akichidis @mwtian