[indexer][test cluster] support indexer backed rpc in cluster test and add some indexer reader tests #19906
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
| .collect(); | ||
|
|
||
| let object_resp = http_client.multi_get_objects(object_digests, None).await?; | ||
| assert_eq!(5, object_resp.len()); |
There was a problem hiding this comment.
assert_eq on object_digests and digests from object_resp?
There was a problem hiding this comment.
I added an assert_eq comparing the results from fullnode and indexer, and actually found a discrepancy due to us not sorting by object ids. Also fixed in the latest commit.
emmazzz
force-pushed
the
emma/indexer-json-test
branch
from
b5bd544
to
b951c52
Compare
emmazzz
force-pushed
the
emma/indexer-json-test
branch
from
03e5eaa
to
e5de934
Compare
|
|
||
| // TODO: this only starts indexer writer and reader (jsonrpc server) today. | ||
| // Consider adding graphql server here as well. | ||
| pub(crate) async fn setup_indexer_backed_rpc( |
There was a problem hiding this comment.
This should simply be the new function of IndexerHandle. It will make this function a lot more discoverable.
| let mut cancellation_tokens = vec![]; | ||
| let database = TempDb::new().unwrap(); | ||
| let pg_address = database.database().url().as_str().to_owned(); | ||
| let indexer_jsonrpc_address = format!("127.0.0.1:{}", get_available_port("127.0.0.1")); |
There was a problem hiding this comment.
There should already be some localhost and port util function somewhere.
| @@ -0,0 +1,84 @@ | |||
| // Copyright (c) Mysten Labs, Inc. | |||
There was a problem hiding this comment.
Consider just naming this file test_indexer_handler
| let mut data_ingestion_path = None; | ||
|
|
||
| if self.indexer_backed_rpc { | ||
| if self.data_ingestion_dir.is_none() { |
There was a problem hiding this comment.
Could this code be moved to line 1138?
There was a problem hiding this comment.
It cannot. self.start_swarm() right after this block uses self.data_ingestion_dir.
Description
This PR adds support in TestCluster to start indexer writer and indexer backed jsonrpc so that any testing done using TestCluster and fullnode jsonrpc can now be easily switched to using indexer jsonrpc. It's a step needed towards deprecation of fullnode jsonrpc. And a few tests are added/adapted from existing rpc tests.
Test plan
Added tests.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.