[move] add return locations to source map #19885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
jordanjennings-mysten
force-pushed
the
return-locs-in-source-map
branch
from
6f95874
to
33204de
Compare
tzakian
approved these changes
Oct 16, 2024
| @@ -47,6 +47,11 @@ macro_rules! record_src_loc { | |||
| .source_map | |||
| .add_parameter_mapping($context.current_function_definition_index(), source_name)?; | |||
| }}; | |||
| (_return: $context:expr, $_type:expr) => {{ | |||
There was a problem hiding this comment.
Nit: I'd probably use return_ here. We usually have the convention of "suffix _ to shadow a keyword" and "prefix _ to mean an unused or ignored variable".
| @@ -907,6 +914,9 @@ fn compile_function_body_impl( | |||
| for (var, _) in ast_function.signature.formals.into_iter() { | |||
| record_src_loc!(parameter: context, var) | |||
| } | |||
| for _type in ast_function.signature.return_type.into_iter() { | |||
There was a problem hiding this comment.
Nit: Same thing here on using a suffix _ for this variable name.
| @@ -1726,6 +1741,9 @@ fn compile_function_body_bytecode( | |||
| function_frame.define_local(&var.value, sig.clone())?; | |||
| record_src_loc!(parameter: context, var); | |||
| } | |||
| for _type in return_type { | |||
jordanjennings-mysten
force-pushed
the
return-locs-in-source-map
branch
from
33204de
to
39d21ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.