[sui-types] avoid deserialization when fetching ID of non-upgraded pa… #19849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
…ckages The `original_package_id` function is showing up in some slow traces, so make it less expensive in the (common) case of grabbing the ID of a non-upgraded package
sblackshear
force-pushed
the
optimize_orig_package_id
branch
from
7dcbab6
to
856819c
Compare
amnn
approved these changes
Oct 16, 2024
tnowacki
reviewed
Oct 16, 2024
| @@ -483,6 +483,10 @@ impl MovePackage { | |||
| /// The ObjectID that this package's modules believe they are from, at runtime (can differ from | |||
| /// `MovePackage::id()` in the case of package upgrades). | |||
| pub fn original_package_id(&self) -> ObjectID { | |||
| if self.version == OBJECT_START_VERSION { | |||
There was a problem hiding this comment.
I forget, packages don't get the lamport timestamp?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ckages
The
original_package_idfunction is showing up in some slow traces, so make it less expensive in the (common) case of grabbing the ID of a non-upgraded package