Uncompressed G1 group elements #19684
Merged
+1,607
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
benr-ml
reviewed
Oct 6, 2024
crates/sui-framework/packages/sui-framework/sources/crypto/bls12381.move
Outdated
Show resolved
Hide resolved
crates/sui-framework/packages/sui-framework/sources/crypto/bls12381.move
Outdated
Show resolved
Hide resolved
crates/sui-framework/packages/sui-framework/sources/crypto/bls12381.move
Outdated
Show resolved
Hide resolved
crates/sui-framework/packages/sui-framework/sources/crypto/group_ops.move
Outdated
Show resolved
Hide resolved
jonas-lj
force-pushed
the
jonas/uncompressed_g1_pts
branch
from
bbf3e68
to
60eb44f
Compare
benr-ml
reviewed
Oct 7, 2024
crates/sui-framework/packages/sui-framework/sources/crypto/bls12381.move
Outdated
Show resolved
Hide resolved
crates/sui-framework/packages/sui-framework/tests/crypto/bls12381_tests.move
Outdated
Show resolved
Hide resolved
crates/sui-framework/packages/sui-framework/tests/crypto/bls12381_tests.move
Outdated
Show resolved
Hide resolved
benr-ml
approved these changes
Oct 10, 2024
jonas-lj
force-pushed
the
jonas/uncompressed_g1_pts
branch
from
49fd06d
to
98a4f06
Compare
jonas-lj
force-pushed
the
jonas/uncompressed_g1_pts
branch
from
98a4f06
to
5fbebb9
Compare
This reverts commit d87f830.
jonas-lj
force-pushed
the
jonas/uncompressed_g1_pts
branch
from
6ead0fc
to
134f8f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, group elements are represented in compressed form and must be decompressed before each operation. This is a rather expensive operation to do, in particular if many elements are used.
This PR introduces a new uncompressed representation of BLS12381-G1 elements and a function to add a vector of uncompressed elements. For 500 terms, computing a sum will be about 100x faster to compute than using compressed representation.
Test plan
Unit tests.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.