Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back the simple test of Random to cluster-test #18594

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

benr-ml
Copy link
Contributor

@benr-ml benr-ml commented Jul 10, 2024

Was reverted in #18585 since the wrong check was committed
(if Self::is_beacon_enabled(wallet_context).await instead of if !Self::is_beacon_enabled(wallet_context).await).

Confirmed that the problem was fixed.

Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 7:14am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 7:14am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 7:14am
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 7:14am

@benr-ml benr-ml marked this pull request as ready for review July 10, 2024 07:27
@benr-ml benr-ml requested a review from aschran July 10, 2024 07:27
@benr-ml benr-ml changed the title Add back a simple test of Random to cluster-test Add back the simple test of Random to cluster-test Jul 10, 2024
@benr-ml benr-ml merged commit b88e5be into main Jul 10, 2024
75 of 78 checks passed
@benr-ml benr-ml deleted the revert-18585-revert-18545-ben/cluster_test_random branch July 10, 2024 12:46
tx-tomcat pushed a commit to tx-tomcat/sui-network that referenced this pull request Jul 29, 2024
Was reverted in MystenLabs#18585 since the
wrong check was committed
(`if Self::is_beacon_enabled(wallet_context).await` instead of `if
!Self::is_beacon_enabled(wallet_context).await`).


[Confirmed](https://github.com/MystenLabs/sui-operations/actions/runs/9870085557/job/27255754698)
that the problem was fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants