-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Examples/Front-end] Tic-tac-toe #18526
Merged
Merged
Commits on Jul 11, 2024
-
## Description Port Move code for the tic tac toe example into the `sui/examples` directory, modernising it in the process: - Standardise the implementation between the owned, shared and multi-sig variants, so that the only differences are relevant to what they need to do differently. In doing this, the owned and multi-sig variants become identical (at least at the level of Move code). - Use transfer-to-object in the "owned" example, to send potential moves to the `Game` object, instead of the admin that owns the game. - Use more Move 2024 features (`syntax(index)`, receiver function aliases, etc). - Improve test coverage ## Test plan New unit tests: ``` tic_tac_toe/move$ sui move test ```
Configuration menu - View commit details
-
Copy full SHA for 3501ecf - Browse repository at this point
Copy the full SHA 3501ecfView commit details -
Configuration menu - View commit details
-
Copy full SHA for e8fc1d3 - Browse repository at this point
Copy the full SHA e8fc1d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bb12a4 - Browse repository at this point
Copy the full SHA 7bb12a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53cd199 - Browse repository at this point
Copy the full SHA 53cd199View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16836c6 - Browse repository at this point
Copy the full SHA 16836c6View commit details -
[Examples/Tic-Tac-Toe] Front-end
## Description Build front-ends for shared and multi-sig tic-tac-toe, using `create-react-dapp`. ## Test plan Manually tested, (screenshots TBD).
Configuration menu - View commit details
-
Copy full SHA for 56d308a - Browse repository at this point
Copy the full SHA 56d308aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e9d57a4 - Browse repository at this point
Copy the full SHA e9d57a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f919dc5 - Browse repository at this point
Copy the full SHA f919dc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for faad2c2 - Browse repository at this point
Copy the full SHA faad2c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f061124 - Browse repository at this point
Copy the full SHA f061124View commit details -
fixup: pnpm workspace unignore tic-tac-toe
Use --ignore-workspace when installing instead.
Configuration menu - View commit details
-
Copy full SHA for 292785b - Browse repository at this point
Copy the full SHA 292785bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5139b2f - Browse repository at this point
Copy the full SHA 5139b2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a7c2b74 - Browse repository at this point
Copy the full SHA a7c2b74View commit details -
Configuration menu - View commit details
-
Copy full SHA for d65e3b4 - Browse repository at this point
Copy the full SHA d65e3b4View commit details -
fixup: Use Polymedia for local explorer
Couldn't get SuiScan's local explorer to work.
Configuration menu - View commit details
-
Copy full SHA for 782d410 - Browse repository at this point
Copy the full SHA 782d410View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb5302d - Browse repository at this point
Copy the full SHA bb5302dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 370f92f - Browse repository at this point
Copy the full SHA 370f92fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b25548 - Browse repository at this point
Copy the full SHA 5b25548View commit details -
This will change for each person, so don't check-in an actual package.
Configuration menu - View commit details
-
Copy full SHA for 2d53664 - Browse repository at this point
Copy the full SHA 2d53664View commit details -
fixup: Address some more comments.
- useExecutor exposes more info about mutation status, we leverage this for the play buttons. - Early return style for validation labels. - Strict equality for address validation. - `<>` instead of `<div>`
Configuration menu - View commit details
-
Copy full SHA for 32bd537 - Browse repository at this point
Copy the full SHA 32bd537View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c56895 - Browse repository at this point
Copy the full SHA 5c56895View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cb3346 - Browse repository at this point
Copy the full SHA 5cb3346View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0915285 - Browse repository at this point
Copy the full SHA 0915285View commit details -
Configuration menu - View commit details
-
Copy full SHA for f308c58 - Browse repository at this point
Copy the full SHA f308c58View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.