[bridge] some fixes to bridge node #18322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
Bridgerz
reviewed
Jun 18, 2024
longbowlu
force-pushed
the
fix-bridge-node
branch
from
4fde480
to
3a590aa
Compare
longbowlu
force-pushed
the
fix-bridge-node
branch
from
3a590aa
to
82ee0c5
Compare
longbowlu
force-pushed
the
fix-bridge-node
branch
from
82ee0c5
to
3a27a55
Compare
longbowlu
force-pushed
the
fix-bridge-node
branch
from
4982f67
to
9254fba
Compare
longbowlu
commented
Jun 21, 2024
Comment on lines
169
to
176
| let eth_client = Arc::new( | ||
| EthClient::<ethers::providers::Http>::new( | ||
| &config.eth_rpc_url, | ||
| HashSet::from_iter(vec![bridge_address]), | ||
| ) | ||
| .await?, | ||
| ); | ||
|
|
There was a problem hiding this comment.
cc @Bridgerz we shouldn't need another instance for EthClient
Bridgerz
approved these changes
Jun 21, 2024
longbowlu
force-pushed
the
fix-bridge-node
branch
from
9254fba
to
a032136
Compare
tx-tomcat
pushed a commit
to tx-tomcat/sui-network
that referenced
this pull request
Jul 29, 2024
## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.