e2e test improvements, and fixes for executor classes #18312
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
hayes-mysten
force-pushed
the
mh--debug-e2e-cache-error-2
branch
from
ef6d48e
to
bf9b474
Compare
hayes-mysten
force-pushed
the
mh--debug-e2e-cache-error-2
branch
2 times, most recently
from
d383cf1
to
bd6733e
Compare
hayes-mysten
force-pushed
the
mh--debug-e2e-cache-error-2
branch
from
bd6733e
to
d4c8a2a
Compare
hayes-mysten
force-pushed
the
mh--debug-e2e-cache-error-2
branch
from
fe192d2
to
dfdb9c8
Compare
hayes-mysten
changed the title
| @@ -13,6 +13,9 @@ runs: | |||
| - uses: pnpm/action-setup@a3252b78c470c02df07e9d59298aecedc3ccdd6d # [email protected] | |||
| with: | |||
| version: 9.1.1 | |||
| - name: Install dependencies | |||
| run: pnpm install --frozen-lockfile | |||
| shell: bash | |||
There was a problem hiding this comment.
it was defaulting to using a new version of turbo that removed commands this job depends on, so e2e test were only triggered on rust changes
| - uses: Swatinem/rust-cache@v2 | ||
| with: | ||
| cache-all-crates: true | ||
| cache-on-failure: true |
There was a problem hiding this comment.
this shaves a few minutes off the build, but doesn't seem to cache builds for things in the repo. Probably needs further improvement
| @@ -197,6 +240,8 @@ export class ParallelTransactionExecutor { | |||
| } | |||
| } | |||
|
|
|||
| this.#lastDigest = results.digest; | |||
There was a problem hiding this comment.
The executor tracks a list of gas coins to use to refill the pool, this contains the coins from failed executions and coins who's balance was too low. we don't track the versions for these coins, because in error cases, they might become invalid. By tracking the digest of the last executed transaction, we can wait for that digest to be indexed before executing the refill transaction, which should ensure the index is up-to-date for all coins used to refill the pool.
| async #refillCoinPool() { | ||
| const batchSize = Math.min( | ||
| this.#coinBatchSize, | ||
| this.#maxPoolSize - (this.#coinPool.length + this.#executeQueue.activeTasks) + 1, | ||
| this.#maxPoolSize - (this.#coinPool.length + this.#pendingTransactions) + 1, |
There was a problem hiding this comment.
Using the number of transaction in the executeQueue was slightly wrong, because they may not have borrowed a coin yet. Instead we should have been counting the coins in the pool + the transactions that are actively borrowing a gas coin
hayes-mysten
force-pushed
the
mh--debug-e2e-cache-error-2
branch
from
2b4310a
to
7ed1c76
Compare
## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.