DKG - Switch to V1 #18233
Merged
DKG - Switch to V1 #18233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
aschran
reviewed
Jun 18, 2024
| @@ -501,12 +505,20 @@ pub struct AuthorityEpochTables { | |||
|
|
|||
| /// Records messages processed from other nodes. Updated when receiving a new dkg::Message | |||
| /// via consensus. | |||
| pub(crate) dkg_processed_messages: DBMap<PartyId, dkg::ProcessedMessage<PkG, EncG>>, | |||
| pub(crate) dkg_processed_messages_v2: DBMap<PartyId, VersionedProcessedMessage>, | |||
| #[deprecated] | |||
There was a problem hiding this comment.
i'd not mark these as deprecated until we actually remove the code that uses the old tables
There was a problem hiding this comment.
i'd rather be explicit about it, they should not be used for new code
aschran
approved these changes
Jun 18, 2024
tx-tomcat
pushed a commit
to tx-tomcat/sui-network
that referenced
this pull request
Jul 29, 2024
## Description Refactor the DKG to allow protocol upgrades of the cryptographic protocol, and migrate to V1 (controlled by a protocol config parameter). ## Test plan Existing tests and the "Continuous" GH workflow. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [x] Protocol: - [x] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the DKG to allow protocol upgrades of the cryptographic protocol, and migrate to V1 (controlled by a protocol config parameter).
Test plan
Existing tests and the "Continuous" GH workflow.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.