[move] Fix issue where varcalls could persist into typing without an error. #17958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
tnowacki
reviewed
May 28, 2024
external-crates/move/crates/move-compiler/src/naming/translate.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-compiler/src/naming/translate.rs
Outdated
Show resolved
Hide resolved
tnowacki
approved these changes
May 30, 2024
cgswords
force-pushed
the
cgswords/var_naming_fix
branch
from
2bac786
to
53420aa
Compare
tx-tomcat
pushed a commit
to tx-tomcat/sui-network
that referenced
this pull request
Jul 29, 2024
…error. (MystenLabs#17958) ## Description This fixes a bug in how var calls were being resolved across naming into typing, when the variable was not a valid macro call target. This also adds a `lambda` feature gate to make error reporting a bit nicer in these cases. ## Test plan New tests cover the crash/bug and ensure it doesn't occur now. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug in how var calls were being resolved across naming into typing, when the variable was not a valid macro call target.
This also adds a
lambdafeature gate to make error reporting a bit nicer in these cases.Test plan
New tests cover the crash/bug and ensure it doesn't occur now.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.