[move-ide] Move analyzer versioning #17929
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
.github/workflows/release.yml
Outdated
| @@ -141,7 +141,7 @@ jobs: | |||
| shell: bash | |||
| run: | | |||
| [ -f ~/.cargo/env ] && source ~/.cargo/env ; cargo build --release && cargo build --profile=dev --bin sui | |||
| cd external-crates/move && cargo build -p move-analyzer --release | |||
| cargo build -p sui-move-lsp --release | |||
There was a problem hiding this comment.
@awelc Do we need to call this out specifically? Does it build as part of cargo build --release?
.github/workflows/release.yml
Outdated
| @@ -156,7 +156,7 @@ jobs: | |||
| done | |||
|
|
|||
| mv ./target/debug/sui${{ env.extention }} ${{ env.TMP_BUILD_DIR }}/sui-debug${{ env.extention }} | |||
| mv ./external-crates/move/target/release/move-analyzer${{ env.extention }} ${{ env.TMP_BUILD_DIR }}/move-analyzer${{ env.extention }} | |||
| mv ./target/release/move-analyzer${{ env.extention }} ${{ env.TMP_BUILD_DIR }}/move-analyzer${{ env.extention }} | |||
There was a problem hiding this comment.
same here, I think we can just remove this line if it builds as part of cargo build --release
There was a problem hiding this comment.
I think all we have to do is add the sui-move-lsp to https://github.com/MystenLabs/sui/blob/main/binary-build-list.json, and it will get packaged automatically, just like the rest of them, as long as it's in the target/release location
There was a problem hiding this comment.
Thank you for pointing that out! I followed the advice, but added move-analyzer there as I believe it should be the name of the binary rather than the build target (from what I see the exe extension is added for Windows build so we should indeed be good there)
Description
We would like to use the same versioning scheme we use for Sui binaries (particularly for
suibinary) for themove-analyzeras well.Both
suiandmove-analyzerbinaries "bundle" the move compiler and being able to tell which version you are using is very useful (and really necessary to avoid discrepancies in the compilation process between the IDE and CLI).It's apparently not possible to have to
move-analyzerbinaries in the repo (one incratesand one inexternal-crates) so I renamed the one inexternal-cratesas it's the one incratesthat is intended to be externally used from now on.Test plan
All existing tests must pass