[bridge] Add print registration info in cli #17908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
is this ready for review? it seems to be against a private branch and I am confused... |
longbowlu
force-pushed
the
add-print-registration-info-in-cli
branch
from
9ca39eb
to
46057eb
Compare
dariorussi
approved these changes
May 29, 2024
| /// Print current registration info | ||
| #[clap(name = "print-bridge-registration-info")] | ||
| PrintBridgeRegistrationInfo { | ||
| #[clap(long = "sui-rpc-url")] |
There was a problem hiding this comment.
I know that you know that I know that you know... but you can just say long when the long name matches the field name. Though maybe was on purpose...
There was a problem hiding this comment.
will fix this in a later PR
| }) | ||
| .collect::<HashMap<_, _>>(); | ||
| let mut authorities = vec![]; | ||
| for (_, member) in move_type_bridge_committee.member_registration { |
There was a problem hiding this comment.
you could work off references if you wanted particularly considering most of the usage is by reference.
Just commenting to be honest, I do not think it matters much given the usage
There was a problem hiding this comment.
yeah we consume it anyway here
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a subcommand to display current registration info.
Test plan
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.