Update docs for the wallet-standard #17901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
Type: Documentation
|
|
hayes-mysten
force-pushed
the
mh--sdk-v1-wallet-standard-docs
branch
from
7345225
to
4675ee5
Compare
hayes-mysten
force-pushed
the
mh--sdk-v1-wallet-standard-docs
branch
from
9151c0f
to
33a3b23
Compare
hayes-mysten
force-pushed
the
mh--sdk-v1-wallet-standard-docs
branch
from
33a3b23
to
b654bfa
Compare
hayes-mysten
force-pushed
the
mh--sdk-v1-wallet-standard-docs
branch
from
b654bfa
to
9a136d5
Compare
Jordan-Mysten
approved these changes
May 28, 2024
| @@ -61,6 +62,7 @@ export function useSignAndExecuteTransaction({ | |||
| const { currentWallet, supportedIntents } = useCurrentWallet(); | |||
| const currentAccount = useCurrentAccount(); | |||
| const client = useSuiClient(); | |||
| const { mutate: reportTransactionEffects } = useReportTransactionEffects(); | |||
There was a problem hiding this comment.
I think it'd also be fine if this just returned a function since hypothetically there's no meaningful loading state or anything here, but this is fine with me too for consistentcy
There was a problem hiding this comment.
Gonna leave this as is for consistency
hayes-mysten
force-pushed
the
mh--sdk-v1-wallet-standard-docs
branch
from
9a136d5
to
6a1dce2
Compare
hayes-mysten
added a commit
that referenced
this pull request
May 28, 2024
## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.