[move-ide] Added on-hover for inlay type hints #17900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
awelc
commented
May 23, 2024
| /// are resolved (the main problem is that adding it enables a drop-down menu | ||
| /// containing options that are not supported for the type definition, such | ||
| /// as go-to-declaration, and which jump to weird locations in the file). | ||
| fn additional_hint_info(sp!(_, t): &N::Type, symbols: &Symbols) -> Option<InlayHintTooltip> { |
There was a problem hiding this comment.
This is the main part (the rest are some refactorings)
| Some(serde_json::to_value(loc).unwrap()) | ||
| }, | ||
| ); | ||
| } | ||
|
|
||
| pub fn def_ide_location(def_loc: &DefLoc, symbols: &Symbols) -> Location { |
There was a problem hiding this comment.
Not a strictly necessary one but I hope we will be able to ultimately support locations in inlay type hints for additional information to be displayed (that's why this was introduced in the first place).
awelc
commented
May 23, 2024
| @@ -136,6 +136,10 @@ pub struct DefLoc { | |||
| } | |||
|
|
|||
| impl DefLoc { | |||
| pub fn new(fhash: FileHash, start: Position) -> Self { | |||
There was a problem hiding this comment.
Also not strictly necessary (for the same reasons as described here) but using it instead of struct constructors made the code look nicer so I left it
rvantonder
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added on-hover when hovering over struct type hints:
Test plan
Verified that on-hover works for struct type hints