-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[move][move-id] Move IDE autocomplete information to IDEInfo form #17889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
cgswords
force-pushed
the
cgswords/autocomplete_ide_info
branch
from
May 24, 2024 22:55
f3fa07a
to
94547ab
Compare
cgswords
changed the title
Move IDE autocomplete information to IDEInfo form
[move][move-id] Move IDE autocomplete information to IDEInfo form
May 24, 2024
cgswords
force-pushed
the
cgswords/ide_info
branch
from
May 28, 2024 19:58
dd98104
to
1d9c5b0
Compare
cgswords
force-pushed
the
cgswords/autocomplete_ide_info
branch
from
May 28, 2024 20:00
94547ab
to
1d20895
Compare
cgswords
force-pushed
the
cgswords/ide_info
branch
from
May 28, 2024 21:59
53912a3
to
77a83b2
Compare
…mputed in typing to be more precise
cgswords
force-pushed
the
cgswords/autocomplete_ide_info
branch
from
May 28, 2024 22:27
278794a
to
10a9b57
Compare
tnowacki
approved these changes
May 28, 2024
ExpandedLambda, | ||
/// Autocomplete information. | ||
AutocompleteInfo(Box<AutocompleteInfo>), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some Rust joy here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds autocomplete information collection to the
IDEInfo
form.Test plan
Testing is difficult without the analyzer calling it with a location, but I anticipate working with Adam on that over the next few days.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.