-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8][16/n][enums/Move] Turn on enums in 2024.alpha #17860
Merged
tzakian
merged 1 commit into
tzakian/move-enums-flavor-version
from
tzakian/move-enums-2024-alpha
May 24, 2024
Merged
[8][16/n][enums/Move] Turn on enums in 2024.alpha #17860
tzakian
merged 1 commit into
tzakian/move-enums-flavor-version
from
tzakian/move-enums-2024-alpha
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
tzakian
force-pushed
the
tzakian/move-enums-flavor-version
branch
from
May 22, 2024 18:04
51696a1
to
8b3f82b
Compare
tzakian
requested review from
amnn,
wlmyng,
stefan-mysten,
emmazzz,
suiwombat,
mystenmark and
joyqvq
as code owners
May 22, 2024 18:04
tzakian
force-pushed
the
tzakian/move-enums-2024-alpha
branch
from
May 22, 2024 18:04
2235aec
to
e9d136b
Compare
tzakian
removed request for
amnn,
emmazzz,
mystenmark,
joyqvq,
suiwombat,
wlmyng and
stefan-mysten
May 22, 2024 18:06
cgswords
reviewed
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cgswords
approved these changes
May 22, 2024
tzakian
force-pushed
the
tzakian/move-enums-flavor-version
branch
from
May 23, 2024 17:17
8b3f82b
to
d8fbeb9
Compare
tzakian
force-pushed
the
tzakian/move-enums-2024-alpha
branch
from
May 23, 2024 17:17
e9d136b
to
c6d23d5
Compare
tzakian
force-pushed
the
tzakian/move-enums-flavor-version
branch
from
May 23, 2024 18:50
d8fbeb9
to
fc81aec
Compare
tzakian
force-pushed
the
tzakian/move-enums-2024-alpha
branch
from
May 23, 2024 18:50
c6d23d5
to
efe3984
Compare
tzakian
force-pushed
the
tzakian/move-enums-flavor-version
branch
from
May 24, 2024 00:42
fc81aec
to
ffa7cab
Compare
tzakian
force-pushed
the
tzakian/move-enums-2024-alpha
branch
from
May 24, 2024 00:42
efe3984
to
3fff910
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turns on enums in move 2024 alpha, and updates the location of tests to reflect that.
Test plan
Update existing tests, and make sure they pass.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.