[gql] expose db_pool_size on ConnectionConfig #17595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlmyng
requested review from
amnn,
stefan-mysten,
emmazzz and
suiwombat
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
stefan-mysten
approved these changes
May 8, 2024
wlmyng
added a commit
that referenced
this pull request
May 9, 2024
There isn't a way to configure `db_pool_size` on `ConnectionConfig` since it's not exposed on `start_server`. This is a simple PR that exposes it, and bumps the default pool size from 3 to 10. This is because we already have a few background tasks in addition to the main graphql service. Existing tests. --- Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ x] GraphQL: Expose an additional parameter `db_pool_size` on `start-server` command so that users can configure how many db connections the graphql service will spin up for its pool. - [ ] CLI: - [ ] Rust SDK:
wlmyng
added a commit
that referenced
this pull request
May 9, 2024
## Description There isn't a way to configure `db_pool_size` on `ConnectionConfig` since it's not exposed on `start_server`. This is a simple PR that exposes it, and bumps the default pool size from 3 to 10. This is because we already have a few background tasks in addition to the main graphql service. ## Test plan Existing tests. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ x] GraphQL: Expose an additional parameter `db_pool_size` on `start-server` command so that users can configure how many db connections the graphql service will spin up for its pool. - [ ] CLI: - [ ] Rust SDK:
wlmyng
added a commit
that referenced
this pull request
May 9, 2024
There isn't a way to configure `db_pool_size` on `ConnectionConfig` since it's not exposed on `start_server`. This is a simple PR that exposes it, and bumps the default pool size from 3 to 10. This is because we already have a few background tasks in addition to the main graphql service. Existing tests. --- Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [x] GraphQL: Expose an additional parameter `db_pool_size` on `start-server` command so that users can configure how many db connections the graphql service will spin up for its pool. - [ ] CLI: - [ ] Rust SDK: ## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
wlmyng
added a commit
that referenced
this pull request
May 9, 2024
## Description There isn't a way to configure `db_pool_size` on `ConnectionConfig` since it's not exposed on `start_server`. This is a simple PR that exposes it, and bumps the default pool size from 3 to 10. This is because we already have a few background tasks in addition to the main graphql service. ## Test plan Existing tests. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [x] GraphQL: Expose an additional parameter `db_pool_size` on `start-server` command so that users can configure how many db connections the graphql service will spin up for its pool. - [ ] CLI: - [ ] Rust SDK: ## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
ebmifa
pushed a commit
that referenced
this pull request
May 16, 2024
## Description There isn't a way to configure `db_pool_size` on `ConnectionConfig` since it's not exposed on `start_server`. This is a simple PR that exposes it, and bumps the default pool size from 3 to 10. This is because we already have a few background tasks in addition to the main graphql service. ## Test plan Existing tests. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [x] GraphQL: Expose an additional parameter `db_pool_size` on `start-server` command so that users can configure how many db connections the graphql service will spin up for its pool. - [ ] CLI: - [ ] Rust SDK: ## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There isn't a way to configure
db_pool_sizeonConnectionConfigsince it's not exposed onstart_server. This is a simple PR that exposes it, and bumps the default pool size from 3 to 10. This is because we already have a few background tasks in addition to the main graphql service.Test plan
Existing tests.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
db_pool_sizeonstart-servercommand so that users can configure how many db connections the graphql service will spin up for its pool.