[move][ide] Add a flag to toggle IDE mode in the compiler #17591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
tnowacki
approved these changes
May 8, 2024
| @@ -687,6 +691,10 @@ pub struct Flags { | |||
| /// included only in tests, without creating the unit test code regular tests do. | |||
| #[clap(skip)] | |||
| keep_testing_functions: bool, | |||
|
|
|||
| /// If set, all warnings are silenced | |||
| #[clap(skip = false)] | |||
There was a problem hiding this comment.
What does skip mean here? Confused because keep_testing_functions is marked as skip
There was a problem hiding this comment.
This omits it from the CLI interface, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a tag to add IDE mode to the compiler, plus uses it to feature gate incomplete dot parsing.
Test plan
A few tests added to ensure it works when on.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.