[core] Cleanup protocol version cheecks in transaction validity check #17530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
aschran
reviewed
May 6, 2024
crates/sui-types/src/transaction.rs
Outdated
| @@ -1490,6 +1490,12 @@ impl VersionedProtocolMessage for TransactionData { | |||
| }); | |||
| } | |||
|
|
|||
| if !protocol_config.random_beacon() && self.uses_randomness() { | |||
There was a problem hiding this comment.
why does this now go in check_version_supported? It doesn't seem to have anything to do with the message version?
There was a problem hiding this comment.
This function doesn't actually just check message version. The next line checks a bunch of feature flags and whether some of the transaction features used are enabled by the config.
There was a problem hiding this comment.
nit, but while you're in the area, maybe rename it to something more representative to what it currently does?
mystenmark
approved these changes
May 10, 2024
lxfind
force-pushed
the
core-consolidate-protocol-checks
branch
from
67c4e71
to
f6ad3f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consolidates protocol version support checks on transactions during validity check.
Specifically, it breaks down the protocol config version checks from authority_server into two pieces:
One notable change is that the randomness check now only checks the protocol config feature, without checking whether the randomness object exists. I believe this is fine because if the randomness object does not exist, it will fail latter when loading input objects anyway. But worth double check @aschran
Test plan
CI
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.