Run simtest code coverage without --config flags #16134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
ebmifa
reviewed
Feb 7, 2024
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| # verify that git repo is clean | ||
| if [[ -n $(git status -s) ]]; then |
There was a problem hiding this comment.
@mystenmark, why do we need this? This workflow is going to be run on ubuntu-ghcloud GH runner. So there should never be the case when repo is not clean
There was a problem hiding this comment.
someone could run the script locally (e.g. to test it) and it could clobber local files
There was a problem hiding this comment.
./scripts/simtest/codecov.sh
shell: /usr/bin/bash -e {0}
env:
CARGO_TERM_COLOR: always
CARGO_INCREMENTAL: 0
CARGO_NET_RETRY: 10
RUSTUP_MAX_RETRIES: 10
RUST_BACKTRACE: short
RUSTDOCFLAGS: -D warnings
CACHE_ON_FAILURE: false
Working directory is not clean. Please commit all changes before running this script. ./scripts/simtest/codecov.sh
shell: /usr/bin/bash -e {0}
env:
CARGO_TERM_COLOR: always
CARGO_INCREMENTAL: 0
CARGO_NET_RETRY: 10
RUSTUP_MAX_RETRIES: 10
RUST_BACKTRACE: short
RUSTDOCFLAGS: -D warnings
CACHE_ON_FAILURE: false
Working directory is not clean. Please commit all changes before running this script.
Is what I was afraid of when this script gets run. I feel like these are two different cases here
ebmifa
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.