Skip to content

Commit

Permalink
Upgrade rustls (#17257)
Browse files Browse the repository at this point in the history
## Description 

Upgrade rustls used in the workspace to a version that fixes
RUSTSEC-2024-0336.
But there are still Sui dependencies using the unpatched version, which
I'm not sure when will be upgraded.

Also, make sure Rust CI runs when Rust workspace config changes.

## Test plan 

CI

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
  • Loading branch information
mwtian authored Apr 20, 2024
1 parent 040701d commit f7bc79f
Show file tree
Hide file tree
Showing 4 changed files with 41 additions and 35 deletions.
5 changes: 5 additions & 0 deletions .github/actions/diffs/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ runs:
- '.github/workflows/codecov.yml'
- '.github/workflows/rust.yml'
- '.github/workflows/external.yml'
- 'Cargo.lock'
- 'Cargo.toml'
- 'deny.toml'
- 'rust-toolchain.toml'
- 'rustfmt.toml'
isDoc:
- 'docs/content/**'
- '*.mdx'
Expand Down
67 changes: 34 additions & 33 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ rusoto_kms = { version = "0.48.0", default_features = false, features = [
russh = "0.38.0"
russh-keys = "0.38.0"
rust-version = "1.56.1"
rustls = { version = "0.21.6", features = ["dangerous_configuration"] }
rustls = { version = "0.21.11", features = ["dangerous_configuration"] }
rustls-pemfile = "1.0.2"
rustversion = "1.0.9"
rustyline = "9.1.2"
Expand Down
2 changes: 1 addition & 1 deletion deny.toml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ ignore = [
"RUSTSEC-2023-0052",
# we don't do RSA signing on Sui (only verifying for zklogin)
"RUSTSEC-2023-0071",
# Unblock until rustls is upgraded.
# A few dependencies use unpatched rustls.
"RUSTSEC-2024-0336",
]
# Threshold for security vulnerabilities, any vulnerability with a CVSS score
Expand Down

0 comments on commit f7bc79f

Please sign in to comment.