Remove simtest lints (#18587)

consensus/core/src/network/metrics.rs

@@ -14,6 +14,7 @@ pub(crate) struct NetworkMetrics {
     pub(crate) network_type: IntGaugeVec,
     pub(crate) inbound: Arc<NetworkRouteMetrics>,
     pub(crate) outbound: Arc<NetworkRouteMetrics>,
+    #[cfg_attr(msim, allow(dead_code))]
     pub(crate) tcp_connection_metrics: Arc<TcpConnectionMetrics>,
     pub(crate) quinn_connection_metrics: Arc<QuinnConnectionMetrics>,
 }
@@ -36,6 +37,7 @@ impl NetworkMetrics {
     }
 }
 
+#[cfg_attr(msim, allow(dead_code))]
 pub(crate) struct TcpConnectionMetrics {
     /// Send buffer size of consensus TCP socket.
     pub(crate) socket_send_buffer_size: IntGauge,

consensus/core/src/network/mod.rs

@@ -46,7 +46,7 @@ pub(crate) mod connection_monitor;
 pub(crate) mod epoch_filter;
 pub(crate) mod metrics;
 mod metrics_layer;
-#[cfg(test)]
+#[cfg(all(test, not(msim)))]
 mod network_tests;
 #[cfg(test)]
 pub(crate) mod test_network;

consensus/core/src/network/test_network.rs

@@ -34,6 +34,7 @@ impl TestService {
         }
     }
 
+    #[cfg_attr(msim, allow(dead_code))]
     pub(crate) fn add_own_blocks(&mut self, blocks: Vec<Bytes>) {
         self.own_blocks.extend(blocks);
     }

crates/sui-e2e-tests/tests/reconfiguration_tests.rs

@@ -713,8 +713,6 @@ async fn do_test_reconfig_with_committee_change_stress() {
 #[cfg(msim)]
 #[sim_test]
 async fn test_epoch_flag_upgrade() {
-    use std::any;
-
     use std::sync::Mutex;
     use sui_core::authority::epoch_start_configuration::EpochFlag;
     use sui_core::authority::epoch_start_configuration::EpochStartConfigTrait;