Skip to content

Commit

Permalink
[sui-node/logging] (#19301)
Browse files Browse the repository at this point in the history
## Description
move warn to error when sui-node cannot send metrics

## Test Plan
it builds

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] REST API:
  • Loading branch information
suiwombat authored Sep 10, 2024
1 parent 9adbe04 commit 91ee7f0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion crates/sui-node/src/metrics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ pub fn start_metrics_push_task(config: &sui_config::NodeConfig, registry: Regist
interval.tick().await;

if let Err(error) = push_metrics(&client, &url, &registry).await {
tracing::warn!("unable to push metrics: {error}; new client will be created");
tracing::error!("unable to push metrics: {error}; new client will be created");
// aggressively recreate our client connection if we hit an error
// since our tick interval is only every min, this should not be racey
client = MetricsPushClient::new(config_copy.network_key_pair().copy());
Expand Down

0 comments on commit 91ee7f0

Please sign in to comment.