Skip to content

Commit

Permalink
Remove legacy bcs registry (#16425)
Browse files Browse the repository at this point in the history
Describe the changes or additions included in this PR.

How did you test the new or updated feature?

---
If your changes are not user-facing and do not break anything, you can
skip the following section. Otherwise, please briefly describe what has
changed under the Release Notes section.

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration
  • Loading branch information
hayes-mysten committed Mar 19, 2024
1 parent c11696c commit 4cd5074
Show file tree
Hide file tree
Showing 42 changed files with 337 additions and 2,704 deletions.
2 changes: 1 addition & 1 deletion apps/wallet/src/ui/app/WalletSigner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export abstract class WalletSigner {
const signature = await this.signData(
messageWithIntent(
IntentScope.PersonalMessage,
bcs.ser(['vector', 'u8'], input.message).toBytes(),
bcs.vector(bcs.u8()).serialize(input.message).toBytes(),
),
);

Expand Down
2 changes: 2 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions sdk/bcs/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ import { decodeStr, encodeStr, splitGenericParameters } from './utils.js';
import type { BcsWriterOptions } from './writer.js';
import { BcsWriter } from './writer.js';

export * from './legacy-registry.js';

// Re-export all encoding dependencies.
export {
bcs,
Expand Down
Loading

0 comments on commit 4cd5074

Please sign in to comment.