fix a couple flaky tests

MystenLabs · Jun 18, 2024 · 18ca350 · 18ca350
1 parent 42d81cb
commit 18ca350
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/sdk/typescript/src/transactions/json-rpc-resolver.ts b/sdk/typescript/src/transactions/json-rpc-resolver.ts
@@ -179,7 +179,7 @@ async function resolveObjectReferences(
 
 	const invalidObjects = Array.from(responsesById)
 		.filter(([_, obj]) => obj.error)
-		.map(([id, _obj]) => id);
+		.map(([_, obj]) => JSON.stringify(obj.error));
 
 	if (invalidObjects.length) {
 		throw new Error(`The following input objects are invalid: ${invalidObjects.join(', ')}`);

diff --git a/sdk/typescript/test/e2e/object-vector.test.ts b/sdk/typescript/test/e2e/object-vector.test.ts
@@ -24,6 +24,8 @@ describe('Test Move call with a vector of objects as input', () => {
 				showEffects: true,
 			},
 		});
+
+		await toolbox.client.waitForTransaction({ digest: result.digest });
 		expect(result.effects?.status.status).toEqual('success');
 		return result.effects?.created![0].reference.objectId!;
 	}
@@ -45,6 +47,7 @@ describe('Test Move call with a vector of objects as input', () => {
 				showEffects: true,
 			},
 		});
+		await toolbox.client.waitForTransaction({ digest: result.digest });
 		expect(result.effects?.status.status).toEqual('success');
 	}
 

diff --git a/sdk/typescript/test/e2e/serial-executor.test.ts b/sdk/typescript/test/e2e/serial-executor.test.ts
@@ -89,12 +89,13 @@ describe('SerialExecutor', () => {
 		const txb3 = new Transaction();
 		txb3.transferObjects([newCoinId], new Ed25519Keypair().toSuiAddress());
 
-		await toolbox.client.signAndExecuteTransaction({
+		const { digest } = await toolbox.client.signAndExecuteTransaction({
 			signer: toolbox.keypair,
 			transaction: txb2,
 		});
 
 		await expect(() => executor.executeTransaction(txb3)).rejects.toThrowError();
+		await toolbox.client.waitForTransaction({ digest });
 
 		// // Transaction should succeed after cache reset/error
 		const result2 = await executor.executeTransaction(txb3);