Skip to content

Commit

Permalink
Lower per object queue age and length thresholds (#19851)
Browse files Browse the repository at this point in the history
## Description 

The original limits on the object queue are set with 1s checkpoint
interval. Having the oldest transaction on an object queued for 1s is
almost tolerable. In hindsight it should be lower than the checkpoint
interval to ensure healthy system. Now checkpoint interval is targeting
0.2s - 0.25s, so lowering the limits further to 0.2s, to ensure smooth
checkpoint constructions.

## Test plan 

CI
PT
Reading `num_rejected_cert_during_overload` metric from validators.

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] REST API:
  • Loading branch information
mwtian committed Oct 15, 2024
1 parent 7a42022 commit 007bc71
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 23 deletions.
4 changes: 2 additions & 2 deletions crates/sui-config/src/node.rs
Original file line number Diff line number Diff line change
Expand Up @@ -874,7 +874,7 @@ pub struct AuthorityOverloadConfig {
}

fn default_max_txn_age_in_queue() -> Duration {
Duration::from_secs(1)
Duration::from_millis(200)
}

fn default_overload_monitor_interval() -> Duration {
Expand Down Expand Up @@ -910,7 +910,7 @@ fn default_max_transaction_manager_queue_length() -> usize {
}

fn default_max_transaction_manager_per_object_queue_length() -> usize {
100
20
}

impl Default for AuthorityOverloadConfig {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,8 @@ validator_configs:
- Twitch
authority-overload-config:
max-txn-age-in-queue:
secs: 1
nanos: 0
secs: 0
nanos: 200000000
overload-monitor-interval:
secs: 10
nanos: 0
Expand All @@ -161,7 +161,7 @@ validator_configs:
safe-transaction-ready-rate: 100
check-system-overload-at-signing: true
max-transaction-manager-queue-length: 100000
max-transaction-manager-per-object-queue-length: 100
max-transaction-manager-per-object-queue-length: 20
execution-cache:
writeback-cache:
max_cache_size: ~
Expand Down Expand Up @@ -315,8 +315,8 @@ validator_configs:
- Twitch
authority-overload-config:
max-txn-age-in-queue:
secs: 1
nanos: 0
secs: 0
nanos: 200000000
overload-monitor-interval:
secs: 10
nanos: 0
Expand All @@ -331,7 +331,7 @@ validator_configs:
safe-transaction-ready-rate: 100
check-system-overload-at-signing: true
max-transaction-manager-queue-length: 100000
max-transaction-manager-per-object-queue-length: 100
max-transaction-manager-per-object-queue-length: 20
execution-cache:
writeback-cache:
max_cache_size: ~
Expand Down Expand Up @@ -485,8 +485,8 @@ validator_configs:
- Twitch
authority-overload-config:
max-txn-age-in-queue:
secs: 1
nanos: 0
secs: 0
nanos: 200000000
overload-monitor-interval:
secs: 10
nanos: 0
Expand All @@ -501,7 +501,7 @@ validator_configs:
safe-transaction-ready-rate: 100
check-system-overload-at-signing: true
max-transaction-manager-queue-length: 100000
max-transaction-manager-per-object-queue-length: 100
max-transaction-manager-per-object-queue-length: 20
execution-cache:
writeback-cache:
max_cache_size: ~
Expand Down Expand Up @@ -655,8 +655,8 @@ validator_configs:
- Twitch
authority-overload-config:
max-txn-age-in-queue:
secs: 1
nanos: 0
secs: 0
nanos: 200000000
overload-monitor-interval:
secs: 10
nanos: 0
Expand All @@ -671,7 +671,7 @@ validator_configs:
safe-transaction-ready-rate: 100
check-system-overload-at-signing: true
max-transaction-manager-queue-length: 100000
max-transaction-manager-per-object-queue-length: 100
max-transaction-manager-per-object-queue-length: 20
execution-cache:
writeback-cache:
max_cache_size: ~
Expand Down Expand Up @@ -825,8 +825,8 @@ validator_configs:
- Twitch
authority-overload-config:
max-txn-age-in-queue:
secs: 1
nanos: 0
secs: 0
nanos: 200000000
overload-monitor-interval:
secs: 10
nanos: 0
Expand All @@ -841,7 +841,7 @@ validator_configs:
safe-transaction-ready-rate: 100
check-system-overload-at-signing: true
max-transaction-manager-queue-length: 100000
max-transaction-manager-per-object-queue-length: 100
max-transaction-manager-per-object-queue-length: 20
execution-cache:
writeback-cache:
max_cache_size: ~
Expand Down Expand Up @@ -995,8 +995,8 @@ validator_configs:
- Twitch
authority-overload-config:
max-txn-age-in-queue:
secs: 1
nanos: 0
secs: 0
nanos: 200000000
overload-monitor-interval:
secs: 10
nanos: 0
Expand All @@ -1011,7 +1011,7 @@ validator_configs:
safe-transaction-ready-rate: 100
check-system-overload-at-signing: true
max-transaction-manager-queue-length: 100000
max-transaction-manager-per-object-queue-length: 100
max-transaction-manager-per-object-queue-length: 20
execution-cache:
writeback-cache:
max_cache_size: ~
Expand Down Expand Up @@ -1165,8 +1165,8 @@ validator_configs:
- Twitch
authority-overload-config:
max-txn-age-in-queue:
secs: 1
nanos: 0
secs: 0
nanos: 200000000
overload-monitor-interval:
secs: 10
nanos: 0
Expand All @@ -1181,7 +1181,7 @@ validator_configs:
safe-transaction-ready-rate: 100
check-system-overload-at-signing: true
max-transaction-manager-queue-length: 100000
max-transaction-manager-per-object-queue-length: 100
max-transaction-manager-per-object-queue-length: 20
execution-cache:
writeback-cache:
max_cache_size: ~
Expand Down

0 comments on commit 007bc71

Please sign in to comment.